Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (7bdebbf) 84.93% compared to head (c349742) 85.02%.
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master    #3769      +/-   ##
==========================================
+ Coverage   84.93%   85.02%   +0.08%     
==========================================
  Files          92       92              
  Lines       13685    13700      +15     
  Branches     3074     3074              
==========================================
+ Hits        11623    11648      +25     
+ Misses       1572     1565       -7     
+ Partials      490      487       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Question: I can declare variables as public in Vyper and the compiler will generate a view getter function on these functions. Example:

totalSupply: public(uint256)

Should it be possible via a kwarg to set the global nonreentrant key there as well?

totalSupply: public(uint256, nonreentrant=True)

This brings up a great point around flipping reentrancy locks to being the default: how would a developer be able to allow the public getter generated to be accessible to a downstream caller contract, who may need to read some properties of the calling contract (maybe in a flash loan setting)

Question: I can declare variables as public in Vyper and the compiler will generate a view getter function on these functions. Example:

totalSupply: public(uint256)

no, you need to write your own getter (EDIT: misread the statement)

Should it be possible via a kwarg to set the global nonreentrant key there as well?

totalSupply: public(uint256, nonreentrant=True)

hmm yea, why not. i was thinking about how to handle this for other decorators like @bundle and other potential decorators in the future, so maybe this works for those as well.